Re: [Cron-bug] Test suite

[Ryan M. Golbeck]

Jeff Bailey <address@hidden> writes:

> It looks like you're doing two tests in one file - I recommend against
> this (And also that tests should be largely silent).  That way when a
> test fails, it will be reported correctly by make check.
>
> A non-0 exit code denotes failure.  I think it's exit(77) says you've
> chosen to skip the test for some reason.

Yup, that was my plan.  Except I just did this this morning and wanted
a quick way to test what I had wrote so that's why I did it like it
is.

I'll convert and separate it properly either tonight or tomorrow
morning.

I had it print something so I knew easily if it failed or not.

I'll probably end up dividing the tests up into sched_* file_*, etc 
to match the interfaces into libcron and test each thing.

The stuff I'm wondering about is how to easily test the private
interfaces too, but I can worry about that later.

The output of make check is really nice, I'm impressed. :)

Ryan

-- 
Ryan Golbeck <address@hidden>
Computer Science, University Of Waterloo
GPG: 1024D/78916B84 -- 1B1B 2A87 3F00 A7FB 40F3  526D 36CF BA44 7891 6B84