|
From: | Pádraig Brady |
Subject: | Re: [PATCH V2] Add support for cksum --algorithm [sm3] |
Date: | Sun, 12 Sep 2021 23:01:48 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Thunderbird/84.0 |
On 12/09/2021 19:13, Pádraig Brady wrote:
This patch set refactors all digest implementations to their own modules, all interfaced through digest.c. All file operations and diagnostics are done in digest.c. All digests are made available through `cksum -a`. Also we add support for SM3 through `cksum -a sm3` only. V2 changes: - Various small fixes to previous patch set. - Simplify b2sum specific code. - Add support for `cksum -c` to infer the algorithm from tagged checksums.
This is pretty much ready to land now I think. I hope to land it tomorrow. There is a question though re default format to use for cksum -a. I.e. should we use --tag format by default for cksum -a, as that is now directly consumable by cksum -c. If we did that though, we'd have to have the opposite option for cksum, so something like `cksum --untagged` to produce the traditional coreutils output format of "$hash $file". I'm undecided. cheers, Pádraig
[Prev in Thread] | Current Thread | [Next in Thread] |