coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: removing fiemap logic from copy.c


From: Pádraig Brady
Subject: Re: removing fiemap logic from copy.c
Date: Sun, 9 May 2021 18:30:47 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Thunderbird/84.0

On 02/05/2021 22:50, Pádraig Brady wrote:
FYI tomorrow I'm going to push a change to
remove the fiemap extent handling logic from cp/mv/install etc.
(Assuming that ok with folks of course).

This is only used on 10 year old linux kernels,
(where SEEK_HOLE is not available).

Also with fiemap we perform an fsync before each copy,
which is best avoided.

The patch is largish, but boring as just removes lines,
so not attaching here.

Will reply with a link when pushed.

As part of this, we should improve the tests on systems
that don't support fiemap, but where we will be using
the new SEEK_DATA logic.

I'll apply the attached to do that before removing the fiemap logic.

cheers,
Pádraig

Attachment: seek-data-tests.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]