coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: fix incorrect `|| fail` pattern in tests


From: Pádraig Brady
Subject: Re: [PATCH] tests: fix incorrect `|| fail` pattern in tests
Date: Sun, 1 Mar 2020 16:30:43 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:73.0) Gecko/20100101 Thunderbird/73.0

On 01/03/2020 15:26, Bernhard Voelker wrote:
On 2020-02-29 22:07, Pádraig Brady wrote:
* tests/ls/stat-free-symlinks.sh: s/|| fail/|| fail=1/.
* tests/misc/tee.sh: Likewise.
* tests/touch/relative.sh: Likewise.
* cfg.mk (sc_prohibit_or_fail): A new syntax-check to avoid this.

Nice catch, these test bugs are quite old (2012, 2012 and 2015).
How did you spot these?

I introduced the same myself in another change,
but noticed when double checking before commit,
then grepping the pattern showed the others.

cheers,
Pádraig



reply via email to

[Prev in Thread] Current Thread [Next in Thread]