[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V6 adjustments]
|
From: |
Pádraig Brady |
|
Subject: |
Re: [PATCH V6 adjustments] |
|
Date: |
Mon, 10 Jun 2019 15:22:15 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 05/06/19 23:46, Pádraig Brady wrote:
> On 05/06/19 16:52, Jeff Layton wrote:
>> On Mon, 2019-06-03 at 03:55 +0100, Pádraig Brady wrote:
>>> The main change here is to refactor code duplication.
>>> In particular this reuses the large print_stat() function
>>> rather than redefining an almost similar print_statx().
>>>
>>
>> These all look fine to me. How did you want to do this? Should we just
>> apply the v6 set, and put yours on top, or would you rather I merge
>> these deltas into the set and send a v7 series?
>
> Cool, I've a couple of tweaks to the --help
> which fixes up the alignment in the man page.
>
> I'll merge all to a single commit in your name,
> and push soon.
More than tweaks, so attaching here.
Will push later today.
thanks,
Pádraig
statx-cached.patch
Description: Text Data
- [PATCH V6 adjustments], Pádraig Brady, 2019/06/02
- [PATCH 1/4] stat: adjustments to statx defines, Pádraig Brady, 2019/06/02
- [PATCH 3/4] stat: fix up __attribute__ (const) declarations, Pádraig Brady, 2019/06/02
- [PATCH 2/4] stat: refactor printf directive parsing, Pádraig Brady, 2019/06/02
- [PATCH 4/4] stat: remove print_statx() and reuse print_stat(), Pádraig Brady, 2019/06/02
- Re: [PATCH V6 adjustments], Jeff Layton, 2019/06/05