Re: [PATCH] maintainer-makefile: fix syntax-check rule for "same.h" [was: [INSTALLED 2/2] ln: use linkat and symlinkat]

[Jim Meyering]

On Sun, Oct 28, 2018 at 12:22 PM Bernhard Voelker
<address@hidden> wrote:
>
> sorry, I forgot to include bug-gnulib, sending again ...
> For reference, the original change in coreutils was published here:
>   https://lists.gnu.org/r/coreutils/2018-10/msg00032.html
>
> On 10/28/18 9:48 AM, Paul Eggert wrote:
> > @@ -291,7 +269,8 @@ do_link (const char *source, const char *dest, int 
> > link_errno)
> >                    if (source_status == 0
> >                        && SAME_INODE (source_stats, dest_stats)
> >                        && (source_stats.st_nlink == 1
> > -                          || same_name (source, dest)))
> > +                          || same_nameat (AT_FDCWD, source,
> > +                                          destdir_fd, dest_base)))
>
> This change leads leads to a FP syntax-check failure:
>
>   $ make syntax-check
>   ...
>   prohibit_same_without_use
>   src/ln.c
>   maint.mk: the above files include same.h but don't use it
>   make: *** [maint.mk:575: sc_prohibit_same_without_use] Error 1
>
> The attached gnulib patch fixes the SC rule - pls. check.

Thanks for fixing that, but...

>-       @h='same.h' re='\<same_name *\(' $(_sc_header_without_use)
+       @h='same.h' re='\<same_name(|at) *\(' $(_sc_header_without_use)

please use the "?" operator instead of an empty alternation, i.e.,

       @h='same.h' re='\<same_name(at)? *\(' $(_sc_header_without_use)