[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] test: avoid FP in chroot-credentials.sh for different group
|
From: |
Bernhard Voelker |
|
Subject: |
Re: [PATCH] test: avoid FP in chroot-credentials.sh for different group list order |
|
Date: |
Sat, 20 Oct 2018 19:22:29 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 10/20/18 11:32 AM, Jim Meyering wrote:
> If you adjust your function to be:
>
> num_sort() { tr -s ' ' '\n' |sort -n; }
>
> then you can make less invasive changes like this:
>
> test "$(chroot --userspec=$NON_ROOT_USERNAME / id -G|num_sort)" = \
> "$(id -G $NON_ROOT_USERNAME|num_sort)" || fail=1
Fair enough. My intention was to catch more errors (while they are
swallowed by the pipe) vs. yours is the smaller change, indeed.
New version attached, pushing soon.
Thanks & have a nice day,
Berny
0001-test-avoid-FP-in-chroot-credentials.sh-for-different.V2.patch
Description: Text Data