Re: [PATCH] expr: plug a memory leak in eval6()

[Pádraig Brady]

On 30/08/17 04:50, Kamil Dudka wrote:
> * src/expr.c (eval6): Free memory allocated by mbs_logical_substr().
> 
> Introduced in v8.27-47-ga9f2be5.  Detected by Coverity Analysis:

> src/expr.c:851: leaked_storage: Variable "s" going out of scope leaks the 
> storage it points to.
> 849|             char *s = mbs_logical_substr (l->u.s, pos, len);
> 850|             v = str_value (s);
> 851|->         }
> 852|         freev (l);
> 853|         freev (i1);

> ---
>  src/expr.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/expr.c b/src/expr.c
> index 795140c..0f6f87a 100644
> --- a/src/expr.c
> +++ b/src/expr.c
> @@ -848,6 +848,7 @@ eval6 (bool evaluate)
>  
>            char *s = mbs_logical_substr (l->u.s, pos, len);
>            v = str_value (s);
> +          free(s);
>          }
>        freev (l);
>        freev (i1);
> -- 2.9.5

Excellent.
Applied

Thank you!