[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] doc: correct technicality in chroot's --help output
From: |
Jim Meyering |
Subject: |
[PATCH] doc: correct technicality in chroot's --help output |
Date: |
Thu, 10 Aug 2017 09:26:00 -0700 |
I noticed a nit in chroot's --help output.
I.e., what if the expansion of $SHELL contains white space or shell
metacharacters? You can argue they'd get what they deserve :-)
But still... we care about robustness, even if it's only in
--help output's implied advice.
* src/chroot.c (usage): Use correct quoting in descriptive diagnostic.
We would run `"$SHELL" -i`, not `${SHELL} -i`.
---
src/chroot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/chroot.c b/src/chroot.c
index 885048f1e..b8b72586d 100644
--- a/src/chroot.c
+++ b/src/chroot.c
@@ -207,7 +207,7 @@ Run COMMAND with root directory set to NEWROOT.\n\
fputs (VERSION_OPTION_DESCRIPTION, stdout);
fputs (_("\
\n\
-If no command is given, run '${SHELL} -i' (default: '/bin/sh -i').\n\
+If no command is given, run '"$SHELL" -i' (default: '/bin/sh -i').\n\
"), stdout);
emit_ancillary_info (PROGRAM_NAME);
}
--
2.13.0
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [PATCH] doc: correct technicality in chroot's --help output,
Jim Meyering <=