Re: groups bug fix, groups test fix and NEWS tweak

[Bernhard Voelker]

On 07/08/2017 06:42 PM, Jim Meyering wrote:
> Here are three proposed patches:
> 
>   groups: do not exit early

Nice catch!

FWIW the bug seems to have been introduced when replacing the
old groups.sh by the groups.c file with commit
  167b8025aca487de001da2448c1aebc2747bc1d3 in v6.11
and some additional checks have been added with immediate exit()
as well with
  71b7ddcdd5c473f9eaf6035b96acc68c14cb379e in v8.15

>   tests: groups-dash.sh: avoid false failure
>   doc: tweak wording

+1 thanks

Have a nice day,
Berny

> 
> From df2c30dca6bb9c07be9b6e5b12ff6d1634e6c417 Mon Sep 17 00:00:00 2001
> From: Jim Meyering <address@hidden>
> Date: Fri, 2 Jun 2017 21:50:04 -0700
> Subject: [PATCH 1/3] doc: tweak wording
> 
> * NEWS (Bug fixes): Tweak wording of the mv/cp-vs-symlink-ownership
> entry and the one about df.
> ---
>  NEWS | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/NEWS b/NEWS
> index b834fa16c..35ba31197 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -4,9 +4,9 @@ GNU coreutils NEWS                                    -*- 
> outline -*-
> 
>  ** Bug fixes
> 
> -  cp and mv now only warn about failure to preserve ownership of symlinks.
> -  cp (without -p) will no longer exit with a failure status, and mv will
> -  also no longer leave such symlinks remaining in the source file system.
> +  cp and mv now merely warn about any failure to preserve symlink ownership.
> +  Before, cp (without -p) would exit with a failure status, and a 
> cross-device
> +  mv would leave such symlinks behind in the source file system.
>    [the bug dates back to the initial implementation]
> 
>    date and touch no longer overwrite the heap with large
> @@ -18,7 +18,7 @@ GNU coreutils NEWS                                    -*- 
> outline -*-
>    [bug introduced in coreutils-8.24]
> 
>    df no longer interacts with excluded file system types, so for example
> -  specifying -x nfs will no longer hang with problematic nfs mounts.
> +  specifying -x nfs no longer hangs with problematic nfs mounts.
>    [bug introduced in coreutils-8.21]
> 
>    split no longer exits when invocations of a --filter return EPIPE.
>