[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH RFC] expand: add support for incremental tab stops
From: |
Keller, Jacob E |
Subject: |
RE: [PATCH RFC] expand: add support for incremental tab stops |
Date: |
Thu, 30 Mar 2017 05:48:21 +0000 |
> -----Original Message-----
> From: Pádraig Brady [mailto:address@hidden]
> Sent: Wednesday, March 29, 2017 7:11 PM
> To: Keller, Jacob E <address@hidden>; address@hidden
> Subject: Re: [PATCH RFC] expand: add support for incremental tab stops
>
> On 29/03/17 15:12, Keller, Jacob E wrote:
> >
> > It looks like there may need to be some work on this for handling zero-width
> characters (like ASCI color sequences) so that it can work correctly for
> colored
> output as well. I'm still looking into it. I'm glad you like it.
>
> Maybe expand could handle these escapes for the general case,
> though note line diff coloring is trivial to add later with something like
>
Yes, my intention was to add support for color sequences in the general case. I
didn't mean to say this patch shouldn't be taken now. I was going to see about
finding a solution for the general case of color sequences.
> diff one two | expand --tabs=1,+8 | idiff ¹
>
This is great, except it doesn't help for programs such as git-diff which
produces its own custom colorings.
Thanks,
Jake
> cheers,
> Pádraig.
>
> ¹ http://www.pixelbeat.org/scripts/idiff