coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] tests: fix tail test race causing false failure


From: Jim Meyering
Subject: Re: [PATCH 2/2] tests: fix tail test race causing false failure
Date: Tue, 31 Jan 2017 22:03:32 -0800

Nice work, eliminating another test race condition.

On Tue, Jan 31, 2017 at 9:41 PM, Pádraig Brady <address@hidden> wrote:
> +grep -F 'become accessible' out  ||                      # usual case
> +grep -F 'has appeared' out       || { fail=1; cat out; } # with slow rmdir

I would find that more readable with a single grep with -E+| for
alternation, instead of two invocations and "||"?

  # The first is the common case, "has appeared" arises with slow rmdir.
  grep -E 'become accessible|has appeared' out || { fail=1; cat out; }



reply via email to

[Prev in Thread] Current Thread [Next in Thread]