coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] build: Properly expand cu_install_program viariable when cro


From: Manolis Ragkousis
Subject: Re: [PATCH] build: Properly expand cu_install_program viariable when cross-compiling
Date: Wed, 25 Jan 2017 17:47:03 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0

On 01/25/17 17:08, Eric Blake wrote:
> On 01/25/17 16:58, Eric Blake wrote:
>>> Do we really need ':='?
>> I am following the GNU Make manual in order to avoid any future
>> recursive errors. It will work with just "=" as well.
> The problem is that local.mk is (for now) an automake source, and
> automake doesn't support := because it is designed to create makefiles
> portable to more than just GNU make.
>
> Maybe down the road automake will require GNU make, at which point we
> can rely on GNU make-isms outside of maint.mk, but for now, we try to
> limit the GNU make extensions to the stuff that doesn't impact automake.
>
I am sorry, I was not aware of this. Keeping things portable is important.
I will just replace ":=" with "=" and send the updated patch.

Manolis




reply via email to

[Prev in Thread] Current Thread [Next in Thread]