[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests: avoid failure when auto selecting factor tests
From: |
Pádraig Brady |
Subject: |
Re: [PATCH] tests: avoid failure when auto selecting factor tests |
Date: |
Sun, 18 Oct 2015 15:31:58 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 18/10/15 10:50, Bernhard Voelker wrote:
> On 10/18/2015 03:41 AM, Pádraig Brady wrote:
>> * tests/factor/run.sh: If this template is found through
>> `grep -El 'print_ver_.* factor'` for example, then just skip it.
> __^______________________________^
> The closing single quote belongs to the quoting of the grep pattern,
> so the `...' doesn't read well here; probably use `grep ... "..."'?
adjusted.
> the __START__ is replaced by the real start value in the
> tests t??.sh, those tests are all skipped now, e.g. t21.sh:
>
> + test 18446744073709551616 = 18446744073709551616
> + skip_ 'ignoring factor test template'
>
> Therefore -1 from me here.
Hah, that was daft :) Changed to:
test "$START" = '__ST''ART__' && skip_ ...
thanks,
Pádraig.