[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint: avoid uniq.c warning from bleeding-edge gcc's -Wstric
|
From: |
Jim Meyering |
|
Subject: |
Re: [PATCH] maint: avoid uniq.c warning from bleeding-edge gcc's -Wstrict-overflow |
|
Date: |
Thu, 15 Oct 2015 09:58:25 -0700 |
On Thu, Oct 15, 2015 at 9:23 AM, Pádraig Brady <address@hidden> wrote:
> On 15/10/15 17:14, Jim Meyering wrote:
>> I build gcc from git regularly, and my first test is to use it to
>> build coreutils.
>> Today's gcc exposed this nit:
...
>> - int nfiles = 0;
>> + unsigned int nfiles = 0;
>
> How about size_t since it's used as an array index?
That variable is used solely to count/index-into argv-related things.
Are there systems that can support more than 2^32 command-line arguments?
Happy to change (consistency?), if you'd like.