Re: [PATCH] maint: tests: fix library position in link line for building shared lib

[Pádraig Brady]

On 10/02/2014 03:26 PM, Nick Alcock wrote:
> * init.cfg (gcc_shared_): -ldl has to be positioned after the object
> files that may rely upon it.  (Fixes tests/cp/nfs-removal-race.sh.)
> ---
>  init.cfg | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/init.cfg b/init.cfg
> index 725ee12..3e74e87 100644
> --- a/init.cfg
> +++ b/init.cfg
> @@ -520,7 +520,7 @@ gcc_shared_()
>    local out=$2
>    shift 2 || return 1
>  
> -  $CC -Wall -shared --std=gnu99 -fPIC -ldl -O2 $* "$in" -o "$out"
> +  $CC -Wall -shared --std=gnu99 -fPIC -O2 $* "$in" -o "$out" -ldl
>  }
>  
>  # There are a myriad of ways to build shared libs,
> 

I couldn't reproduce the failure even with -Wl,--as-needed
but I agree the above is better so pushed that.

thanks,
Pádraig.