coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] maint: ensure "Co-authored-by" in commit message has an email ad


From: Bernhard Voelker
Subject: [PATCH] maint: ensure "Co-authored-by" in commit message has an email address
Date: Sun, 13 Jul 2014 16:12:29 +0200

Otherwise, the script "gitlog-to-changelog" would issue a warning
during 'make dist':

  ./build-aux/gitlog-to-changelog  --since=2008-02-08 > /dev/null
  gitlog-to-changelog: warning: missing email address for Bernhard \
  Voelker.
  gitlog-to-changelog: warning: missing email address for Niels Möller

* scripts/git-hooks/commit-msg: Add a check if a "Co-authored-by:"
line has an email address.
---
 scripts/git-hooks/commit-msg | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/scripts/git-hooks/commit-msg b/scripts/git-hooks/commit-msg
index 559a0ea..4bd038a 100755
--- a/scripts/git-hooks/commit-msg
+++ b/scripts/git-hooks/commit-msg
@@ -133,6 +133,13 @@ sub check_msg($$)
   $buf =~ /^ *Signed-off-by:/mi
     and return q(do not use "Signed-off-by:");
 
+  if ($buf =~ /^Co-authored-by:/mi)
+    {
+      # Ensure gitlog-to-changelog finds the email address in "Co-authored-by".
+      $buf =~ /^Co-authored-by:.*<.*?@.*\..*>/mi
+        or return q(use email address in "Co-authored-by:");
+    }
+
   return '';
 }
 
-- 
1.8.4.5




reply via email to

[Prev in Thread] Current Thread [Next in Thread]