Re: [PATCH] use libcrypto routines in gnulib

[Pádraig Brady]

On 12/03/2013 12:03 AM, Pádraig Brady wrote:
> On 12/02/2013 10:48 PM, Paul Eggert wrote:
>> On 12/02/2013 01:05 PM, Pádraig Brady wrote:
>>> each project would have
>>> to add LIB_CRYPTO_MD5 etc. to their list of libs similarly
>>> to the coreutils patch I had inline in my previous mail.
>>
>> Thanks for explaining.
>>
>> I tried that for Emacs and came up with the patch
>> appended to this message.  Unfortunately, it means that Emacs
>> is now linked with a command of this form:
>>
>>   gcc $(objects) ... -lcrypto -lcrypto -lcrypto -lcrypto ...

> I separated them to give support for picking the best
> library for a particular routine.  Separating the libs
> now means we could do this transparently in future.
> However this probably is a bit over engineered, and
> selection on a per library basis is fine.
> 
> I've adjusted my gnulib patch to only export a single LIB_CRYPTO,
> and that can be transparently mapped to any other crypto libraries
> that we might add in future. Adjusted patch is attached.

Seem like I messed this up, and it doesn't work when SHA512 isn't available,
while any of the others are. I noticed this failure on the libcrypto
available on solaris 10.

I'm thinking the simple adjustment attached might be the best fix.

thanks,
Pádraig.

libcrypto-partial-fix.patch
Description: Text Data