coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: coreutils: FIXMEs in 2013


From: Pádraig Brady
Subject: Re: coreutils: FIXMEs in 2013
Date: Fri, 29 Nov 2013 11:28:56 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

On 11/29/2013 11:23 AM, Bernhard Voelker wrote:
> On 11/29/2013 11:10 AM, Pádraig Brady wrote:
>> On 11/29/2013 09:16 AM, Bernhard Voelker wrote:
>>>      1      src/df.c:246:  MEGABYTES_OPTION  /* FIXME: remove long opt in 
>>> Aug 2013 */
>> Nuke it please.
> 
> Great, thanks.
> 
> Have a nice day,
> Berny
> 
> 
>>From 5ca7178614935b01f4db4bb625ef3e0947da718e Mon Sep 17 00:00:00 2001
> From: Bernhard Voelker <address@hidden>
> Date: Fri, 29 Nov 2013 11:43:45 +0100
> Subject: [PATCH 1/2] df: remove long-obsolescent --megabytes option
> 
> This option has been undocumented for 12 years (commit d1772031),
> and warned about for a year (453ce92f).

Minor nit is we usually refer to commits
using their git describe representation:

commit FILEUTILS-4_1_4-23-gd177203
commit v8.17-43-g453ce92

Otherwise is fine to push.

thanks,
Pádraig



reply via email to

[Prev in Thread] Current Thread [Next in Thread]