Re: RFC: df --output=name to show specified file names

[Pádraig Brady]

On 11/22/2013 01:48 PM, Bernhard Voelker wrote:
> On 11/22/2013 03:19 AM, Pádraig Brady wrote:
>> I was looking at disk usage today and found that being able
>> to output the specified file names in the display would be useful.
>> Consider the new 'Name' column in:
>>
>> $ df --o=target,name,pcent /var/*
>> Mounted on Name          Use%
>> /          /var/cache     71%
>> /          /var/lib       71%
>> /          /var/local     71%
>> /run       /var/lock       1%
>> /          /var/log       71%
>> /run       /var/run        1%
>> /          /var/spool     71%
>> /var/tmp   /var/tmp       71%
>> /          /var/www       71%
>>
>> The attached implements this.
>> Worth adding?
> 
> Yes, this looks quite useful - and as it comes quite cheap
> regarding providing the name in the code I think it's worth
> adding.

Cool.

>> One caveat is that the Name is '-' if you don't specify any arguments to df,
>> so therefore if you output all columns by using --output without a parameter,
>> you'll get a redundant column. I suppose one might suppress this column in 
>> that case?
> 
> I'd leave the "-" column ... "full" output is full output, ;-)
> and I always have a strange feeling when a tool misses some
> information in "full" output in one case while it outputs
> it in the other case.
> But I have no strong preference for this. It's up to you.

Yes I'll leave as is. It's a minor artefact.

> Now to the patch:

I agree with all your improvements.

thanks,
Pádraig.