Re: [PATCH] stty: add support for "stick" parity

[Pádraig Brady]

On 11/17/2013 11:24 AM, Colin Leitner wrote:
> Hi,
> 
> sorry for posting the patch without any context.
> 
>> This seems fairly general and worthwhile. I found some info here:
>> http://www.lothosoft.ch/thomas/libmip/markspaceparity.php
>>
>> I would change "stick" to "constant" in the patch probably.
> 
> it's the nomenclature from termios(3).

Yes it's in the man pages and in the linux headers.
More importantly this seems to be the common nomenclature
used for this feature generally, so while it's
it's best to stay with "stick".

> This also indicates that
> the libmip library must be fairly old, because CMSPAR has been
> part of the public linux headers for quite a while (older than
> 2.6.32).
> 
>> Also I remember this recently in passing on lkml...
>> http://article.gmane.org/gmane.linux.usb.general/96740
>> which references:
>> http://comments.gmane.org/gmane.linux.kernel/1584028
>> which only adds C_CMSPAR(tty) as an internal define now,
>> which hints that this might not be well supported generally?
> 
> Yeah, it's almost as exotic as CDTRDSR, but at least
> documented and supported by a few serial drivers. I ran into
> the missing feature when I tried to test some Linux driver
> patches.

Pushed.

thanks,
Pádraig.