[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] shred: fix direct I/O failures for last write to file
|
From: |
Jim Meyering |
|
Subject: |
Re: [PATCH] shred: fix direct I/O failures for last write to file |
|
Date: |
Thu, 7 Nov 2013 07:20:17 -0800 |
On Thu, Nov 7, 2013 at 6:37 AM, Pádraig Brady <address@hidden> wrote:
> Since the previous patch renabled direct I/O that was disabled on most
> (file) systems in coreutils 6.0, it reactivates a bug that was present
> since 5.3.0 when direct I/O was added.
>
> I.E. there can now be an odd sized direct I/O write at the end of file,
> which will trigger an EINVAL write error which is not currently handled.
> The attached patch should fix it up.
Nice patch (and archaeology).