Re: [PATCH] groups,id: add -0, --null option

[Pádraig Brady]

On 09/01/2013 10:35 PM, Bernhard Voelker wrote:
> The attached patch implements the -0,--null option for groups(1)
> and id(1) as discussed in
> 
>   http://bugs.gnu.org/9987
> 
> and
> 
>   http://lists.gnu.org/archive/html/bug-coreutils/2011-11/msg00024.html
> 
> and as mentioned on Padraig's TODO list:
> 
>   http://www.pixelbeat.org/patches/coreutils/inbox_apr_2013.html
>   TODO --> "group -0 to support group names with spaces etc."

Thanks for doing this!

> 
> A nit regarding the new test:
> I was reluctant to use getent(1) to get a reasonable list of users.
> Is that portable on all supported platforms?
> Therefore, I've just used /etc/passwd.
> Now as I'm writing this, I'm sure this will fail with NIS
> where a "+" entry is used.  Can I use "getent passwd"?

Tests are more flexible in that we can skip where not supported.
This works on GNU/Linux, Solaris and FreeBSD at least:

  getent passwd | cut -d: -f1

So I'd try that || skip_ 'getent is not available'

thanks,
Pádraig.