Re: uniq with sort-like "--key" support

[Pádraig Brady]

On 02/13/2013 05:34 PM, Assaf Gordon wrote:
> Hello Jim,
>
> Jim Meyering wrote, On 02/13/2013 12:05 PM:
> > Assaf Gordon wrote:
> > > Assaf Gordon wrote, On 02/13/2013 11:45 AM:
> > ...
> > > > One more update with two changes:
> > >   ...
> > >   src/uniq_sort_common.h | 1096 ++++++++++++++++++++++++++++++++++++++++++++++++
> >
> > Hi Gordon.
> > Thanks a lot for working on this long-requested change.
> > I don't have time to review it, but please change the name of that
> > new header file.  First, we use hyphens (not underscores) in file names.
> > Did you consider any names that evoke "key spec parsing"?
> > Then, the name would still be apropos if someday it's used by a program
> > other than sort and uniq.
>
> This was just a proof-of-concept, so I wanted to have minimal changes that would 
> "just work".
>
> What would be the recommended way to compartmentalize this functionality?
> 1. put it in "src/key-spec-parsing.h", and have each program (e.g. uniq.c) do 
> "#include" ?
> or
> 2. split it into "src/key-spec-parsing.h" and "src/key-spec-parsing.c" (with all the 
> "src/local.mk" associated changes) - but removing the "static" from all the variables/functions?

2 is more standard/flexible.

thanks,
Pádraig.