[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] build: remove redundant dependency: $(PROGRAMS): lib/libcoreutil
From: |
Jim Meyering |
Subject: |
[PATCH] build: remove redundant dependency: $(PROGRAMS): lib/libcoreutils.a |
Date: |
Wed, 03 Oct 2012 19:31:14 +0200 |
FYI,
While it looks small and "easy", this change was a fix to a
decidedly hard-to-diagnose problem that arose only once I tried
to use a compiled-from-C program to generate a file like primes.h.
Such a program must not depend on libcoreutils.a. Otherwise all
of lib/*.o would also be among the dependents of $(BUILT_SOURCES),
and there is currently no way to stage the building of those
dependents. Building them out of order is fatal, usually ending
with link failures due to undefined rpl_* symbols.
>From 852930e88a263bb2e6a6e328dfc7af081637e5cc Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Tue, 18 Sep 2012 21:57:38 +0200
Subject: [PATCH] build: remove redundant dependency: $(PROGRAMS):
lib/libcoreutils.a
* src/local.mk: Remove the above dependency.
A soon-to-be-added new program, make-prime-list, must not depend
on that, since it is used to create a BUILT_SOURCES file.
That dependency is already handled via the ..._LD_ADD variables,
and so that redundant dependency has so far been harmless.
---
src/local.mk | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/local.mk b/src/local.mk
index 0f9e000..98259fa 100644
--- a/src/local.mk
+++ b/src/local.mk
@@ -293,8 +293,6 @@ src_kill_LDADD += $(LIBTHREAD)
# for pthread
src_sort_LDADD += $(LIB_PTHREAD)
-$(PROGRAMS): lib/libcoreutils.a
-
# Get the release year from lib/version-etc.c.
RELEASE_YEAR = \
`sed -n '/.*COPYRIGHT_YEAR = \([0-9][0-9][0-9][0-9]\) };/s//\1/p' \
--
1.8.0.rc0.18.gf84667d
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [PATCH] build: remove redundant dependency: $(PROGRAMS): lib/libcoreutils.a,
Jim Meyering <=