[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build: work with new glibc when not optimizing
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] build: work with new glibc when not optimizing |
|
Date: |
Fri, 31 Aug 2012 13:51:17 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
On 08/31/2012 12:18 PM, Jim Meyering wrote:
> Eric Blake wrote:
>> Newer glibc hates unconditional use of FORTIFY_SOURCE when optimization
>> is disabled but -Werror is in effect.
>>
>> * configure.ac (FORTIFY_SOURCE): Make conditional.
>> ---
>>
>> Copied from a trick I used in libvirt.
>
> My only request would be to change the comment to say with which version
> of glibc this change starts being useful. Saying "newer glibc" sounds
> fine now, but is guaranteed to be misleading in a year or two.
Good point. I amended it to call out glibc 2.15, and pushed.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature