Re: cp preserves mode with --no-preserve=mode

[Bernhard Voelker]

On 08/07/2012 12:59 PM, Ondrej Oprala wrote:
> Hi,
>  here's the new patch. Everything should be in order now.
> Cheers,
>  Ondrej.
> 

As the new variable "explicit_no_preserve" is only used for
the mode, I find its name is a bit confusing (because it's
too general).

Furthermore (and more important), the bug is not yet fixed
for directories:

  $ mkdir d
  $ chmod 705 d
  $ touch d/x
  $ chmod 405 d/x
  $ src/cp --no-preserve=mode -r d d2
  $ find d d2 -ls
  15335447    4 drwx---r-x   2 berny    users        4096 Aug  7 13:28 d
  15335450    0 -r-----r-x   1 berny    users           0 Aug  7 13:28 d/x
  15335458    4 drwx---r-x   2 berny    users        4096 Aug  7 13:28 d2
  15335471    0 -rw-r--r--   1 berny    users           0 Aug  7 13:28 d2/x

The mode of d2 should be 755.

Have a nice day,
Berny