Re: ifdef HAVE_DECL_

[Eric Blake]

[adding gnulib]

On 06/13/2012 03:45 AM, Karel Zak wrote:
> On Wed, Jun 13, 2012 at 11:32:33AM +0200, Karel Zak wrote:
>  
>>  More complex (and I hope without false positives) solution:
>  
>  well... ;-)
> 
>>
>>  for decl in $(awk '/define HAVE_DECL_.*ac_have_decl/ { print $2 }' 
>> configure); do 
>>     grep -rnE '[[:blank:]]*#[[:blank:]]*if(ndef|def)[[:blank:]]*'$decl *; 
>> done | sort -u
>>

>>  gnulib/lib/argp-parse.c:882:#ifdef HAVE_DECL_PROGRAM_INVOCATION_NAME
>>  gnulib/lib/argp-parse.c:886:#ifdef HAVE_DECL_PROGRAM_INVOCATION_SHORT_NAME
> 
>  this seems like a bug

Indeed.  Coreutils isn't using gnulib's argp-parse, but other projects are.

> 
>>  gnulib/lib/error.c:103:#  ifndef HAVE_DECL_STRERROR_R
>>  gnulib/lib/fpending.h:24:#ifndef HAVE_DECL___FPENDING
>>  gnulib/lib/strtoimax.c:31:# ifndef HAVE_DECL_STRTOULL
>>  gnulib/lib/strtoimax.c:40:# ifndef HAVE_DECL_STRTOLL

> 
>  and this like false positives (there is #if before #ifndef)

Yes, those are false positives.

> 
>>  m4/strndup.m4:27:#ifndef HAVE_DECL_STRNDUP
> 
>  not sure

Like argp-parse.c, this is indeed a bug in gnulib; and in this case, it
does affect coreutils.

-- 

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature