[PATCH] tests: misc/tty-eof: increase timeout to avoid unwarranted failure

[Jim Meyering]

The misc/tty-eof test would fail infrequently (just enough to be
annoying) maybe 1 in 5 or 10, yet not enough to investigate...
until today, when the failure interfered with making a release.

Until recently that test was always skipped (and hence even easier to ignore)
for me because I had not installed the perl-Expect package that it requires.

It would fail like this:

FAIL: misc/tty-eof
==================
F: 1: YSBiCg==
F: 1: a b
F: 1: 780509149 4
F: 1: a b
F: 1: a b
F: 1: a b
F: 1: a b
F: 1: a b
F: 1: 7557d2f3a6ad1a3a8ebd23a94ab0c642  -
F: 1:      1    a b
F: 1: 0000000 020141 005142
F: 1: a b
F: 1:
F: 1:                                        a b
F: 1: 90ce62edf2fe4940e041a68b13e7b5f9d02bbf51  -
F: 1: afa36e61f94d23fa2869cc1ca3c7a0855ecb7f3d3305e446e7566d1f  -
F: 1: 01186fcf04b4b447f393e552964c08c7b419c1ad7a25c342a0b631b1967d3a27  -
F: 1: 
adf433b1ea7db8dec7ca64f88f4c8bc5403a1ac1d3540ae0229c79fc8d84e3db4dd9616605c
61215ee7c50da0a97d0e2  -
F: 1: 
ae206702ea661de518d6451ee5b76fe0120429239b73838301991a294bc2628c0b9bbe79d06
b1ab0610a66e9ce7d7e16cdcbdc244058befefc03c5d9cce54357  -
F: 1: a b
F: 1: a b
tty-eof: sort didn't exit after ^D from standard input
F: 1: 08271     1
F: 1: a b
F: 1: a b
F: 1: a b
F: 1: a
F: 1: a b
F: 1: a b
F: 1:       1       2       4

The part that matters is that sort failed to exit.
What it really means is that sort+^D failed to exit before
the 1-second timeout expired.  That gives it away, since
this is reproducible only when I'm running hundreds of tests via
"make -j20 check", and never in isolation.

The timeout was too short.

I'm running 50 or 100 parallel builds with the new, longer timeout.
40 passes and counting...

If they all pass, I'll push the following:

>From e41761321d7e7c8d9e40c7a9d19af80774351e43 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Thu, 10 May 2012 16:20:38 +0200
Subject: [PATCH] tests: misc/tty-eof: increase timeout to avoid unwarranted
 failure

* tests/misc/tty-eof: Increase timeout from 1s to 10s, to avoid
unwarranted failure under heavy load.
---
 tests/misc/tty-eof | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/misc/tty-eof b/tests/misc/tty-eof
index 9e86613..e9eed2e 100755
--- a/tests/misc/tty-eof
+++ b/tests/misc/tty-eof
@@ -75,7 +75,7 @@ $@
       $exp->expect (0, '-re', "^a b\\r?\$");
       my $found = $exp->expect (1, '-re', "^.+\$");
       $found and warn "F: $found: " . $exp->exp_match () . "\n";
-      $exp->expect(1, 'eof');
+      $exp->expect(10, 'eof');
       # Expect no output from cut, since we gave it no input.
       defined $found || $cmd =~ /^cut/
         or (warn "$ME: $cmd didn't produce expected output\n"),
--
1.7.10.1.487.ga3935e6