Re: [PATCH] tests: new discriminator-based test for sort -n and -h

[Jim Meyering]

Paul Eggert wrote:
> The coauthors of this change are myself, Drew Kutilek, and James Wendt.
> * tests/Makefile.am (TESTS): Add misc/sort-discrim.
> * tests/misc/sort-discrim: New file, which tests a discriminator-based
> implementation of 'sort'.  Coreutils doesn't use this implementation
> yet, but the test is useful anyway.

Please add lines like these at the end of your log message:

Co-authored-by: Drew Kutilek <...>
Co-authored-by: James Wendt <...>

Then, gitlog-to-changelog will do what you'd expect when generating
the ChangeLog file that is included in each distribution tarball.

Jim "not fit to review anything at this hour" ;-)

> ---
>  tests/Makefile.am       |    1 +
>  tests/misc/sort-discrim |   87 
> +++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 88 insertions(+), 0 deletions(-)
>  create mode 100755 tests/misc/sort-discrim
>
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index d7a1837..c25d4e8 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -240,6 +240,7 @@ TESTS =                                           \
>    misc/sort-continue                         \
>    misc/sort-debug-keys                               \
>    misc/sort-debug-warn                               \
> +  misc/sort-discrim                          \
>    misc/sort-files0-from                              \
>    misc/sort-float                            \
>    misc/sort-merge                            \
> diff --git a/tests/misc/sort-discrim b/tests/misc/sort-discrim
> new file mode 100755
> index 0000000..d0db649
> --- /dev/null
> +++ b/tests/misc/sort-discrim
> @@ -0,0 +1,87 @@
> +#!/bin/sh
> +# Test discriminator-based sorting.
> +
> +# Copyright (C) 2012 Free Software Foundation, Inc.
> +
> +# This program is free software: you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation, either version 3 of the License, or
> +# (at your option) any later version.
> +
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +
> +. "${srcdir=.}/init.sh"; path_prepend_ ../src
> +print_ver_ sort
> +
> +# Set limit variables.
> +getlimits_
> +
> +# These tests are designed for a 'sort' implementation that uses a
> +# discriminator, i.e., a brief summary of a key that may have lost info,
> +# but whose ordering is consistent with that of the original key.
> +# The tests are useful even if 'sort' does not use this representation.
> +
> +# Test lexicographic sorting.
> +
> +# A long-enough string so that it overruns a small discriminator buffer size.
> +long_prefix='aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
> +seq -f "$long_prefix%5.0f" 10000 > exp || fail=1
> +sort -R exp | LC_ALL=C sort > out || fail=1
> +compare out exp || fail=1
> +
> +
> +# Test numeric sorting.
> +
> +# These tests are designed for an internal representation that ordinarily 
> looks
> +# the number plus two decimal digits, but if -h is
> +# used it looks at one decimal place plus a 4-bit SI prefix value.
> +# In both cases, there's an extra factor of 2 for the sign.
> +max_int200=$(expr $UINTMAX_MAX / 200) &&
> +max_frac200=$(printf '%.2d' $(expr $UINTMAX_MAX / 2 % 100)) &&
> +max_int320=$(expr $UINTMAX_MAX / 320) &&
> +max_frac320=$(expr $UINTMAX_MAX / 32 % 10) &&
> +( printf -- "\
> +    -$UINTMAX_OFLOW
> +    -$UINTMAX_MAX
> +    -${max_int200}0.1
> +    -${max_int200}0
> +    -${max_int200}0.0
> +    -${max_int320}0.1
> +    -${max_int320}0
> +    -${max_int320}0.0
> +    -$max_int200.${max_frac200}1
> +    -$max_int200.$max_frac200
> +    -$max_int320.${max_frac320}1
> +    -$max_int320.$max_frac320
> +" &&
> +  seq -- -10 .001 10 &&
> +  printf "\
> +    $max_int320
> +    $max_int320.$max_frac320
> +    $max_int320.${max_frac320}1
> +    $max_int200
> +    $max_int200.$max_frac200
> +    $max_int200.${max_frac200}1
> +    ${max_int320}0
> +    ${max_int320}0.0
> +    ${max_int320}0.1
> +    ${max_int200}0
> +    ${max_int200}0.0
> +    ${max_int200}0.1
> +    $UINTMAX_MAX
> +    $UINTMAX_OFLOW
> +"
> +) > exp || fail=1
> +
> +for opts in -n -h; do
> +  sort -R exp | LC_ALL=C sort $opts > out || fail=1
> +  compare out exp || fail=1
> +done
> +
> +Exit $fail