coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: add missing sys/types.h for ls speed-up test


From: Jim Meyering
Subject: Re: [PATCH] tests: add missing sys/types.h for ls speed-up test
Date: Sun, 19 Feb 2012 18:45:28 +0100

Jérémy Compostella wrote:

>> Thank you for the report and the patch.
>> Please tell us what type/version of compiler/system you're using.
>> It's good to include that information, especially since ssize_t
>> is supposed to be defined via stdio.h.  Then it is clear that this
>> change is working around a problem with non-conforming systems.
> Here the requested information:
> - linux kernel: Linux Apollo 3.2.0-rc7+ #75 SMP Thu Jan 5 18:14:54 CET
>   2012 x86_64 GNU/Linux
> - gcc (Debian 4.4.5-8) 4.4.5
> - libc6-dev 2.11.2-10

Thanks.
I've adjusted your commit log to explain why:

>From 933989eca67bd82f011595937002cc284c98772d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Compostella?= <address@hidden>
Date: Sun, 19 Feb 2012 15:38:15 +0100
Subject: [PATCH] tests: ls/getxattr-speedup: include <sys/types.h> for older 
headers

Modern <stdio.h> provides ssize_t, but the one from Debian's
libc6-dev 2.11.2-10 apparently does not.
* tests/ls/getxattr-speedup: Also include <sys/types.h>.
---
 tests/ls/getxattr-speedup |    1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/ls/getxattr-speedup b/tests/ls/getxattr-speedup
index 2b7a1f3..a35dd69 100755
--- a/tests/ls/getxattr-speedup
+++ b/tests/ls/getxattr-speedup
@@ -28,6 +28,7 @@ print_ver_ ls
 cat > k.c <<'EOF' || framework_failure_
 #include <errno.h>
 #include <stdio.h>
+#include <sys/types.h>

 static unsigned long int n_calls;

--
1.7.9.1.245.gbbe07



reply via email to

[Prev in Thread] Current Thread [Next in Thread]