coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

id.c comments [was: [PATCH] doc: update for ISO/IEC 80000-13]


From: Eric Blake
Subject: id.c comments [was: [PATCH] doc: update for ISO/IEC 80000-13]
Date: Tue, 15 Nov 2011 11:51:24 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1

On 11/15/2011 11:25 AM, Bob Proulx wrote:
>>> Perhaps it may be easier to read as:
>>>
>>> On GNU/Hurd hosts, identification functions (getuid, getgid, etc.) can
>>> fail and return -1.
>>
>> I prefer that, too.  Thanks.
>> Would you care to adjust it?
> 
> Perhaps the latin abbrevation can be removed here?  I don't think the
> wording for "etc." neither meaning "and so forth" nor for "and other
> things" really fits this case here anyway.
> 
>   On GNU/Hurd hosts, identification functions (getuid, getgid, and
>   others) can fail and return -1.

Here's what I pushed on top of Paul's latest patch, which already
dropped several of the confusing "etc." instances that were proposed at
one point in this thread.

From 97842f0b9779b0f74a6560bf9c80870de1d3708d Mon Sep 17 00:00:00 2001
From: Eric Blake <address@hidden>
Date: Tue, 15 Nov 2011 11:48:51 -0700
Subject: [PATCH] id: tweak comment

* src/id.c (main): Replace confusing use of "etc.".
---
 src/id.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/id.c b/src/id.c
index 9fa93f8..8f7ce9e 100644
--- a/src/id.c
+++ b/src/id.c
@@ -201,9 +201,9 @@ main (int argc, char **argv)
     }
   else
     {
-      /* POSIX says getuid etc. cannot fail, but they can fail under
-         GNU/Hurd and a few other systems.  Test for failure by
-         checking errno.  */
+      /* POSIX says identification functions (getuid, getgid, and
+         others) cannot fail, but they can fail under GNU/Hurd and a
+         few other systems.  Test for failure by checking errno.  */
       uid_t NO_UID = -1;
       gid_t NO_GID = -1;

-- 
1.7.7.1


-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]