coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] maint: speed up make check (vc_exe_in_TESTS)


From: Pádraig Brady
Subject: [PATCH] maint: speed up make check (vc_exe_in_TESTS)
Date: Mon, 17 Oct 2011 11:25:55 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0

When running single tests I noticed a delay of about 3s at the end
when vc_exe_in_TESTS was running.  This is mainly due to
running sed for each file under tests/ which can be avoided like:

diff --git a/tests/check.mk b/tests/check.mk
index d45c288..ac7be1a 100644
--- a/tests/check.mk
+++ b/tests/check.mk
@@ -29,8 +29,8 @@ vc_exe_in_TESTS: Makefile
                $(srcdir)/Makefile.am                                   \
            | sed 's/^  *//;/^\$$.*/d;/^$(_w) =/d'; }                   \
            | tr -s '\012\\' '  ' | fmt -1 | sort -u > t1 &&            \
-         for f in `cd $(top_srcdir) && build-aux/vc-list-files $(subdir)`; do \
-           f=`echo $$f|sed 's!^$(subdir)/!!'`;                         \
+         for f in `cd $(top_srcdir) && \
+          build-aux/vc-list-files $(subdir) | sed 's!^$(subdir)/!!'`; do \
            test -f "$$f" && test -x "$$f" && echo "$$f";               \
          done | sort -u > t2 &&                                        \
          diff -u t1 t2 || exit 1;                                      \

I've went further in the attached patch though and
simplified the test to avoid temp files etc.

cheers,
Pádraig.

Attachment: vc_exe-speedup.diff
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]