Re: [PATCH] tests: improve message in 'require_membership_in_two_groups_' function

[Jim Meyering]

Bernhard Voelker wrote:
> I noticed the message
>   env COREUTILS_GROUPS=users cdrom make check
> in Bruno Haible's check results.
> The syntax of the proposed command is obviously wrong.
> Running this command would result in:
>   env: cdrom: No such file or directory
>
> From 4989d18cc4a2e5a0ac4147c6c147bf574e6448a3 Mon Sep 17 00:00:00 2001
> From: Bernhard Voelker <address@hidden>
> Date: Thu, 1 Sep 2011 11:11:06 +0200
> Subject: [PATCH] tests: improve message in 
> 'require_membership_in_two_groups_' function
>
> * tests/init.cfg (require_membership_in_two_groups_): add quotes
> around the suggested groups for the COREUTILS_GROUPS variable.
>
> Signed-off-by: Bernhard Voelker <address@hidden>
> ---
>  tests/init.cfg |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tests/init.cfg b/tests/init.cfg
> index 023ab9b..b2ae67b 100644
> --- a/tests/init.cfg
> +++ b/tests/init.cfg
> @@ -303,7 +303,7 @@ are a member of at least two groups, then rerun this test 
> with
>  COREUTILS_GROUPS set in your environment to the space-separated list
>  of group names or numbers.  E.g.,
>
> -  env COREUTILS_GROUPS='users cdrom' make check
> +  env COREUTILS_GROUPS='\''users cdrom'\'' make check

Thanks for the patch.  I've queued it.

Log nits: I removed the Signed-off-by line (you're the Author, after all)
and capitalized the first word in the "Add quotes..." sentence.

>From 13187d0c6bb22af5ad08248f7b131e61cd06820c Mon Sep 17 00:00:00 2001
From: Bernhard Voelker <address@hidden>
Date: Thu, 1 Sep 2011 11:11:06 +0200
Subject: [PATCH] tests: improve message in
 'require_membership_in_two_groups_' function

* tests/init.cfg (require_membership_in_two_groups_): Add quotes
around the suggested groups for the COREUTILS_GROUPS variable.
---
 tests/init.cfg |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tests/init.cfg b/tests/init.cfg
index 7e05d0d..56df033 100644
--- a/tests/init.cfg
+++ b/tests/init.cfg
@@ -295,7 +295,7 @@ are a member of at least two groups, then rerun this test 
with
 COREUTILS_GROUPS set in your environment to the space-separated list
 of group names or numbers.  E.g.,

-  env COREUTILS_GROUPS='users cdrom' make check
+  env COREUTILS_GROUPS='\''users cdrom'\'' make check

 '
      ;;
--
1.7.7.rc0.362.g5a14