Re: [PATCH 3/8] split: add tests

[Pádraig Brady]

On 30/04/11 14:31, Jim Meyering wrote:
> +for total_n_lines in 5 3000 20000; do
> +  for i in 2 51 598; do
> +    # Don't create too many files/processes.
> +    case $i:$total_n_lines in 2:5);; *) continue;; esac

So the other combos are only for developer debug?
A comment to clariy would be good.
Perhaps they could be enabled if RUN_VERY_EXPENSIVE_TESTS ?

> +
> +    seq $total_n_lines > in || framework_failure_

The `seq` line should be moved to the outer loop

> +    split -l$i --filter='xz > $FILE.xz' in out- || fail=1
> +    xz -dc out-* > out || fail=1
> +    compare in out || fail=1
> +    rm -f in out*

Ditto for `rm -f in`

> +  done
> +done

cheers,
Pádraig.