Re: [PATCH] copy: adjust fiemap handling of sparse files

[Pádraig Brady]

On 19/03/11 12:07, Jim Meyering wrote:
> Pádraig Brady wrote:
>> On 18/03/11 13:19, Pádraig Brady wrote:
>>> Bah humbug. Looks like there is no such issue.
>>> This actually seems like an issue in a coreutils test script,
>>> which made it seem like the SYNC done by `filefrag -vs` was ineffective.
>>
>> Proposed fix attached.
> 
> Thanks!  Here's a new version of your patch:
> 
> I've adjusted your new function to modify the actual arrays,
> which lets us simplify the caller.
> I've also added two die message "$ME: " prefixes I'd forgotten.

Cool. I'd considered splice but was worried about side effects,
which I might not notice due to my Perl inexperience.

> Is filefrag's -s option portable enough for us to rely on it?

I'll add a -s param to the first use of filefrag, to catch that.
If FIEMAP_FLAG_SYNC is not implemented by the kernel then the
test will fail anyway as CP won't be doing it's internal sync.

thanks for the perl tutorial,
much appreciated!

Pádraig.