Re: [coreutils] [PATCH] copy, tee: assume EINTR is always defined: remove #ifdefs

[Jim Meyering]

Eric Blake wrote:

> On 01/30/2011 08:40 AM, Jim Meyering wrote:
>> FYI, I'm pushing this to the fiemap-copy branch
>> that will shortly be pulled to master.
>>
>>>From 372479c4afb7f3da2cd72e200a2afe65d718cb42 Mon Sep 17 00:00:00 2001
>> From: Jim Meyering <address@hidden>
>> Date: Sun, 30 Jan 2011 16:12:56 +0100
>> Subject: [PATCH] copy, tee: assume EINTR is always defined: remove #ifdefs
>>
>> Don't use "#ifdef EINTR".  dd.c has been doing that since 2004.
>> * src/copy.c (sparse_copy): Remove #ifdef...#endif around EINTR use.
>> * src/tee.c (tee_files): Remove #ifdef...#endif around EINTR use.
>> If we need it, add something like this in system.h:
>> /* When EINTR is not defined, define it to an improbable value
>>    so that each use does not have to be #ifdef'd.  */
>
> Actually, the gnulib errno module (which we already use) guarantees
> pretty much ALL posix-defined errno values.

As you probably know, EINTR is not on gnulib's list.

> There's probably other
> #ifdef E* that you could scrub.

Actually no.  At least not that I could see:

  $ git grep -E 'ifn?def E' src|sort -u
  src/expr.c:#ifdef EVAL_TRACE
  src/extent-scan.h:#ifndef EXTENT_SCAN_H
  src/install.c:#ifdef ENABLE_MATCHPATHCON
  src/stty.c:#ifdef ECHOCTL
  src/stty.c:#ifdef ECHOKE
  src/stty.c:#ifdef ECHOPRT
  src/system.h:#ifndef ENODATA
  src/true.c:#ifndef EXIT_STATUS