coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[coreutils] Re: gnulib/coreutils: Error on coreutils git submodule updat


From: Jim Meyering
Subject: [coreutils] Re: gnulib/coreutils: Error on coreutils git submodule update
Date: Thu, 20 Jan 2011 10:10:41 +0100

Rob Vermaas wrote:
> Hi Jim,
>
> sorry for mailing you directly, but I'm having trouble getting the
> latest coreutils code. I get this error on 'git submodule update':
>
> fatal: reference is not a tree: 568779402439589832419c90e3f8193496a39613
> Unable to checkout '568779402439589832419c90e3f8193496a39613' in
> submodule path 'gnulib'
>
> This has to do with this commit:
> http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=blobdiff;f=gnulib;h=568779402439589832419c90e3f8193496a39613;hp=104aca8300d01a80889f70f41a4dce7e044f9476;hb=5c75d1da85d8da86e7a0083d4fbbd8d4de50305b;hpb=34ece0b0a1e19f1faef8edfe3d59c5a2f5209369
>
> Somehow the commit is not in the gnulib git repository. Any idea
> what's going on there?

Hi Rob,

Thanks for the heads-up.
That is indeed my mistake.

I ran "git syncsub" vs. a local gnulib repository
in which I had committed-but-not-pushed a change.

We now have a public-submodule-commit make target in the gnulib-provided
maint.mk, and it checks for just that condition.  However, it is currently
run only at release time.  This makes it apparent that we should check
this all the time...  At least via "make distcheck", and probably via a
server-side hook to prevent the offending "push" as well.

I've just updated (careful to use a public commit,
not the mountlist pair that is waiting for an ACK ;-)
and pushed the fix:

>From 634440238940bd4b216af62c88658073a84e69ec Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Thu, 20 Jan 2011 10:00:42 +0100
Subject: [PATCH] build: update gnulib submodule to latest

The previous gnulib submodule reference was to a non-public commit.
Reported by Rob Vermaas.
---
 gnulib |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gnulib b/gnulib
index 5687794..680c7ff 160000
--- a/gnulib
+++ b/gnulib
@@ -1 +1 @@
-Subproject commit 568779402439589832419c90e3f8193496a39613
+Subproject commit 680c7ff005a2eb96b0903e5200cc28de273555c7
--
1.7.3.5



reply via email to

[Prev in Thread] Current Thread [Next in Thread]