[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [coreutils] might as well release yet again
From: |
Jim Meyering |
Subject: |
Re: [coreutils] might as well release yet again |
Date: |
Fri, 14 Jan 2011 13:47:38 +0100 |
Pádraig Brady wrote:
> On 14/01/11 11:22, Jim Meyering wrote:
>> I'm thinking of making yet another coreutils release.
>> The du bug isn't that big a deal, but still.
>> I prefer not to mix bug fixes and feature additions,
>> and a few of the latter are coming.
>
> I'd be inclined not to bother with a new release
> unless we can have more consequential fixes.
Ok. I'm happy to put off the release for a couple weeks,
and to include features like your join auto-format.
Besides, there's Eric's sort vs multi-thread safety point.
>> Does anyone have patches that would fit in a bug-fix release?
...
> I noticed a small issue this morning.
> Assaf, the following warning shouldn't be printed, right?
> The attached patch addresses that.
>
> printf 'test\n1\n' | join --header -a1 - /dev/null
> test
> join: file 1 is not in sorted order
> 1
Good catch.
> Subject: [PATCH] join: ensure --header skips the order check with empty files
>
> * src/join.c: Skip the header even if one of the files is empty.
> * tests/misc/join: Add a test case.
> * NEWS: Mention the fix
> ---
> NEWS | 3 +++
> src/join.c | 12 ++++++++----
> tests/misc/join | 6 ++++++
> 3 files changed, 17 insertions(+), 4 deletions(-)
That looks perfect. Thanks!