[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[coreutils] [PATCH] maint: add a missed fadvise-tests module
From: |
Pádraig Brady |
Subject: |
[coreutils] [PATCH] maint: add a missed fadvise-tests module |
Date: |
Mon, 15 Nov 2010 14:57:51 +0000 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 |
commit b19733bb42e1897afd93f40aeca83e76013f7075
Author: Pádraig Brady <address@hidden>
Date: Mon Nov 15 09:36:16 2010 +0000
maint: add a missed fadvise-tests module
* gl/modules/fadvise-tests: Add the module previously missed
in commit 63b5e816, 2010-07-14, "fadvise: new module ...".
* gl/tests/test-fadvise.c: Add a comment as to why we don't
check return values.
diff --git a/gl/modules/fadvise-tests b/gl/modules/fadvise-tests
new file mode 100644
index 0000000..61e223d
--- /dev/null
+++ b/gl/modules/fadvise-tests
@@ -0,0 +1,10 @@
+Files:
+tests/test-fadvise.c
+
+Depends-on:
+
+configure.ac:
+
+Makefile.am:
+TESTS += test-fadvise
+check_PROGRAMS += test-fadvise
diff --git a/gl/tests/test-fadvise.c b/gl/tests/test-fadvise.c
index 10b448f..cd2f8bf 100644
--- a/gl/tests/test-fadvise.c
+++ b/gl/tests/test-fadvise.c
@@ -21,6 +21,13 @@
#include "fadvise.h"
+/* We ignore any errors as these hints are only advisory.
+ * There is the chance one can pass invalid ADVICE, which will
+ * not be indicated, but given the simplicity of the interface
+ * this is unlikely. Also not returning errors allows the
+ * unconditional passing of descriptors to non standard files,
+ * which will just be ignored if unsupported. */
+
int
main (void)
{
- [coreutils] [PATCH] maint: add a missed fadvise-tests module,
Pádraig Brady <=