[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [coreutils][patch] seq: User specified terminator
From: |
Jim Meyering |
Subject: |
Re: [coreutils][patch] seq: User specified terminator |
Date: |
Wed, 27 Oct 2010 21:40:22 +0200 |
Pádraig Brady wrote:
> On 27/10/10 18:27, William Plusnick wrote:
>> I added a way to specify the string printed after the last number in the
>> seq command, as suggested by a comment. I am not sure how helpful this
>> option is, because I personally don't use the seq command much. I also
>> added documentation to both usage (and, in effect, the man page) and
>> coreutils.texi. It was so small that I didn't see any need for a test.
>> It went over the ten line limit, but is pretty trivial and the large
>> majority is documentation, so I am unsure if I need to sign anything. I
>> also forgot to add a NEWS entry, but I am not even sure this will get
>> accepted, yet. :-)
>
> Thanks for the patch.
> We usually need a pretty strong use case for adding a new option,
> but I can't think of a use for this to be honest.
> I realise this was a "FIXME" in the code,
> so perhaps someone can think of a use.
I wrote that comment simply because I thought that
hard-coding "\n" might not always be desirable.
Given that no one has ever complained, so
simply removing the comment might be best.