Re: [coreutils] [PATCH] maint: update sample test template

[Eric Blake]

On 10/01/2010 03:00 PM, Jim Meyering wrote:
> > -if test "$VERBOSE" = yes; then
> > -  set -x
> > -  FIXME --version
> > -fi
>
> The VERBOSE=yes ->  "set -x" part is handled in init.sh, so it's
> fine to remove that, but the other, --version-printing part...
>
> It's intended to identify the program(s) under test so that we see in
> the log whether it is indeed the just-compiled version or some other.
> That particular problem doesn't arise very often, but when it has happened
> before, it's been hard to diagnose.

Good point.

> If we retain it, it would have to go *after* the path_prepend_ invocation.
>
>      test "$VERBOSE" = yes&&  FIXME --version
>
> What do you think?

I'll add that back to the template, and to the last few recently-added 
tests.

--
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org