[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [coreutils] [PATCHv2] stat: print SELinux context when available
From: |
Jim Meyering |
Subject: |
Re: [coreutils] [PATCHv2] stat: print SELinux context when available |
Date: |
Fri, 01 Oct 2010 22:41:02 +0200 |
Eric Blake wrote:
> * src/stat.c (default_format): Include context when present.
> * NEWS: Update blurb explaining the replacement for -Z.
> ---
>
> Definitely nicer than the first attempt, but still controversial on
> whether we want to do this at all. I'm 70:30 for (I use Fedora's stat
> -Z regularly, and would hate to make Fedora have to maintain it's -Z
> patch in perpetuity).
>
> NEWS | 5 ++++-
> src/stat.c | 45 +++++++++++++++++++++++++++++++++++++++++++--
> 2 files changed, 47 insertions(+), 3 deletions(-)
>
> diff --git a/NEWS b/NEWS
> index dd8a18b..719ac9c 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -75,7 +75,10 @@ GNU coreutils NEWS -*-
> outline -*-
>
> stat no longer accepts the --context (-Z) option. Initially it was
> merely accepted and ignored, for compatibility. Starting two years
> - ago, with coreutils-7.0, its use evoked a warning.
> + ago, with coreutils-7.0, its use evoked a warning. Printing the
> + SELinux context can be done with the %C format directive, and the
> + default output when no format is specified now automatically
> + includes %C when context information is available.
This is a close call, but I think it is justified.
stat's default format should show as much information
as possible, and no one should be parsing it.
SELinux context, when available, deserves to be printed here.
ACK.
- [coreutils] stat and SELinux context, Eric Blake, 2010/10/01
- Re: [coreutils] stat and SELinux context, Pádraig Brady, 2010/10/01
- [coreutils] [PATCH] stat: print SELinux context when available, Eric Blake, 2010/10/01
- Re: [coreutils] [PATCHv2] stat: print SELinux context when available, Pádraig Brady, 2010/10/05
- Re: [coreutils] [PATCHv2] stat: print SELinux context when available, Jim Meyering, 2010/10/05
- Re: [coreutils] [PATCHv2] stat: print SELinux context when available, Pádraig Brady, 2010/10/05
- Re: [coreutils] [PATCHv2] stat: print SELinux context when available, Eric Blake, 2010/10/05
- Re: [coreutils] [PATCHv2] stat: print SELinux context when available, Jim Meyering, 2010/10/05
- [coreutils] [PATCH] stat: drop %C support when printing file system details, Eric Blake, 2010/10/05
- Re: [coreutils] [PATCH] stat: drop %C support when printing file system details, Eric Blake, 2010/10/05
- Re: [coreutils] [PATCH] stat: drop %C support when printing file system details, Jim Meyering, 2010/10/05