Re: [PATCH v2 1/3] config.sub: add managarm-{mlibc,kernel} targets

[Dmitry V. Levin]

On Sat, Sep 17, 2022 at 11:34:46PM +0200, Arsen Arsenović wrote:
> To achieve this, the `kernel' pseudo-OS value was added, intended to
> identify targets requiring a kernel-specific compiler and base system.
> 
> Signed-off-by: Arsen Arsenović <arsen@aarsen.me>
> ---
> Evening,
> 
> This is version 2 of the config.sub patch we sent in for Managarm.
> This version locks down on the `kernel' pseudo-OS value so that it can only be
> used with OSes that have a separate kernel target, as to not be too
> generic/confusing.
> 
> Apologies for taking a while to submit v2, and thank you in advance.

Applied, thanks,

[...]
> @@ -1341,6 +1341,10 @@ EOF
>               kernel=linux
>               os=`echo "$basic_os" | sed -e 's|linux|gnu|'`
>               ;;
> +     managarm*)
> +             kernel=managarm
> +             os=$(echo $basic_os | sed -e 's|managarm|mlibc|')
> +             ;;

This hunk has been amended to follow the style accepted in this file.

> @@ -1776,12 +1783,24 @@ case $kernel-$os in
>               ;;
>       uclinux-uclibc* )
>               ;;
> -     -dietlibc* | -newlib* | -musl* | -relibc* | -uclibc* )
> +     managarm-mlibc* )
> +             ;;
> +     managarm-kernel* )
> +             ;;

These two cases have been merged into a single case.

> +     -dietlibc* | -newlib* | -musl* | -relibc* | -uclibc* | -mlibc* )
>               # These are just libc implementations, not actual OSes, and thus
>               # require a kernel.
>               echo "Invalid configuration \`$1': libc \`$os' needs explicit 
> kernel." 1>&2
>               exit 1
>               ;;
> +     -kernel* )
> +             echo "Invalid configuration \`$1': -kernel must not appear on 
> its own." 1>&2
> +             exit 1
> +             ;;
> +     *-kernel* )
> +             echo "Invalid configuration \`$1': Kernel \`$kernel' does not 
> support -kernel." 1>&2
> +             exit 1
> +             ;;

The wording here has been amended to be more in line with the diagnostics
about libc above.


-- 
ldv