Re: config.guess returns incorrect platform for alpine

[Dmitry V. Levin]

On Wed, Nov 04, 2020 at 04:50:37PM -0800, Cheng XU wrote:
> That’s right. The ldd check is more reliable as  the compiler is usually not 
> available in a fresh Alpine docker container. And as shown in my the example 
> in my previous email, the compiler check actually does not work in the latest 
> alpine system, even when the compiler is installed.
> 
> Moreover, the ldd check will only rewrite the result on musl platform. It has 
> not effect on non-musl platforms.

If this is the case, then the ldd based check should be performed first,
and if its result is either musl or GNU, then the compiler based check
shouldn't be performed at all.

Thanks,

> Lastly, I merely restore the old behavior, which has never shown any issue on 
> non-musl systems.
> 
> Best Regards,
> 
> Cheng
> On Nov 4, 2020, 4:45 PM -0800, Dmitry V. Levin <ldv@altlinux.org>, wrote:
> > On Wed, Nov 04, 2020 at 04:36:10PM -0800, Cheng XU wrote:
> > > I think my patch fulfills all your requirements. It has no side effect on 
> > > non-musl platform.
> > >
> > > Best Regards,
> > >
> > > Cheng
> >
> > Looks like it performs the compiler based check, then overrides its result
> > with the result of the ldd based check. This means that you treat the ldd
> > based check as the most trustworthy of these two.
> >
> > Thanks,
> >
> > > On Nov 4, 2020, 4:08 PM -0800, Dmitry V. Levin <ldv@altlinux.org>, wrote:
> > > > On Wed, Nov 04, 2020 at 02:57:08PM -0800, Cheng XU wrote:
> > > > > Please find the patch in the attachment. Thanks.
> > > > >
> > > > > Best Regards,
> > > > >
> > > > > Cheng
> > > >
> > > > If you're about to reintroduce the ldd check, please make sure the most
> > > > trustworthy of these checks (whatever it is) is attempted first and its
> > > > result is not discarded, please do not penalize non-musl platforms
> > > > unnecessarily.
> > > >
> > > > Thanks,
> > > >
> > > > > On Nov 4, 2020, 2:39 PM -0800, Ben Elliston <bje@air.net.au>, wrote:
> > > > > > On Wed, Nov 04, 2020 at 02:31:05PM -0800, Cheng XU wrote:
> > > > > >
> > > > > > > Thanks for the info. However, it seems that the referenced issue 
> > > > > > > is
> > > > > > > only valid for the old version of Alpine. For the latest version,
> > > > > > > the `ldd --version` works just fine. As shown in the below, the 
> > > > > > > old
> > > > > > > config.guess reports the correct result in a fresh alpine docker
> > > > > > > container, while the new config.guess does not. Therefore, I think
> > > > > > > we should just keep the original `ldd --version` check. There is 
> > > > > > > no
> > > > > > > harm to do so.
> > > > > >
> > > > > > Please suggest a patch, then.
> > > > > >
> > > > > > Thanks,
> > > > > > Ben
> > > >
> > > > --
> > > > ldv
> >
> > --
> > ldv

-- 
ldv