config-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] * config.sub (s390|s390x): Fix vendor output for s390/s390x.


From: John Ericson
Subject: Re: [PATCH] * config.sub (s390|s390x): Fix vendor output for s390/s390x.
Date: Wed, 24 Jun 2020 10:56:08 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0

Alexander,

(disclaimer: I am not the official maintainer, just someone who put a in a bunch of time reorganizing `config.sub`.)

If go to the bottom of config.sub, there is a section where the vendor is inferred for none was provided. I recommend adding the IBM logic there, so we go from forcing IBM to defaulting it, rather than forcing IBM to nothing at all.

John

On 6/20/20 7:30 AM, Alexander Egorenkov wrote:
Setting vendor always to 'ibm' causes problems with gcc
and glibc when building a cross-compiler on s390x host for
s390x target, e.g. in case of buildroot.

See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95712

Signed-off-by: Alexander Egorenkov <egorenar@linux.ibm.com>
---
  config.sub | 11 ++---------
  1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/config.sub b/config.sub
index 0820805..fcd21a1 100755
--- a/config.sub
+++ b/config.sub
@@ -2,7 +2,7 @@
  # Configuration validation subroutine script.
  #   Copyright 1992-2020 Free Software Foundation, Inc.
-timestamp='2020-06-18'
+timestamp='2020-06-20'
# This file is free software; you can redistribute it and/or modify it
  # under the terms of the GNU General Public License as published by
@@ -1146,14 +1146,6 @@ case $cpu-$vendor in
                cpu=mipsallegrexel
                vendor=sony
                ;;
-       s390-*)
-               cpu=s390
-               vendor=ibm
-               ;;
-       s390x-*)
-               cpu=s390x
-               vendor=ibm
-               ;;
        tile*-*)
                os=${os:-linux-gnu}
                ;;
@@ -1237,6 +1229,7 @@ case $cpu-$vendor in
                        | pyramid \
                        | riscv | riscv32 | riscv64 \
                        | rl78 | romp | rs6000 | rx \
+                       | s390 | s390x \
                        | score \
                        | sh | shl \
                        | sh[1234] | sh[24]a | sh[24]ae[lb] | sh[23]e | she[lb] 
| sh[lb]e \



reply via email to

[Prev in Thread] Current Thread [Next in Thread]