Re: [PATCH] config.sub is not idempotent

[John Ericson]

Sorry Ben. I forgot to hoist up the `$verbose ||` when I got rid of `msgs` to make the "PASS: ..." independent, so those were printing unconditionally. Fixed now.

John

On 07/30/18 02:04, John Ericson wrote:

Oh OK. Here is another version of the 3rd patch.

Firstly, I realized my own other mistake:  I had improperly limited the *-* patterns in a few case when fixing shellcheck errors. Existing globs shouldn't be restricted. [I had been narrowly extending the "special case" rules below to just additionally match normalized things and nothing more, and then "solved" some shellcheck errors the wrong way.]

The intent with the 3rd patch is: if "food" is accepted then "foo-*" should also be. If we allow skipping the vendor we should also allow it to be provided, even if this isn't excised by the new canonicalization tests.

Secondly, fixed the testsuite to match that. That seems simpler, actually.

John

On 07/30/18 01:57, Ben Elliston wrote:

There are now two separate tests for config.sub. I would like the test results tracked separately.

Perhaps it is time to switch to a Dejagnu test harness. 😆

Ben

_______________________________________________
config-patches mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/config-patches

0003-config.sub-Make-idemopotent.patch
Description: Text document