|
From: | John Ericson |
Subject: | Re: [PATCH 2/4] Indent maybe_os stuff ahead of refactor |
Date: | Tue, 1 May 2018 16:12:18 -0400 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
Also, I meant to _over_ indent so the next patch would be less noisy. Sorry my commit message was very confusing as to that intention.
Not knowing what you want, I'll do 4 patches: 1. Make all indent exclusively tab-based like the majority of the file, and with `| ` leading successive lines of big, multi-line case patterns. 2. Add more tabs to _properly_ :) over-indent this time preparation of (3) 3. My 4 component patch from before 4. My `arm*-*-none-eabi` patch from before I'll fix the commit messages to match the ` * config.sub ...` style too. Let me know if you want anything additional/different. Cheers, John On 05/01/18 01:46, Ben Elliston wrote:
This change is fine in principle, but I didn't agree with your indenting rules. ;-) Please re-do your patch #3 using current master. Cheers, Ben
[Prev in Thread] | Current Thread | [Next in Thread] |