[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
grep >/dev/null instead of grep -q
From: |
Karl Berry |
Subject: |
grep >/dev/null instead of grep -q |
Date: |
Thu, 28 May 2015 20:37:39 GMT |
Hi Ben,
For your consideration ...
grep -q is not supported on the sadly-still-widely-used Solaris 5.10. I
realize that at least some, maybe all, of these tests only execute on
other systems, but it somehow seems simpler and more readable to just
always redirect to /dev/null instead of worrying about whether it is
necessary.
Oh, and may as well quote the periods in ld.so.1, just in case ...
--- ORIG/config.guess 2015-05-03 16:23:59.000000000 -0700
+++ config.guess 2015-05-28 09:55:33.985617905 -0700
@@ -193,3 +193,3 @@
if echo __ELF__ | $CC_FOR_BUILD -E - 2>/dev/null \
- | grep -q __ELF__
+ | grep __ELF__ >/dev/null
then
@@ -697,3 +697,3 @@
if echo __LP64__ | (CCOPTS= $CC_FOR_BUILD -E - 2>/dev/null) |
- grep -q __LP64__
+ grep __LP64__ >/dev/null
then
@@ -917,3 +917,3 @@
esac
- objdump --private-headers /bin/sh | grep -q ld.so.1
+ objdump --private-headers /bin/sh | grep 'ld\.so\.1' >/dev/null
if test "$?" = 0 ; then LIBC="gnulibc1" ; fi
@@ -927,3 +927,3 @@
if echo __ARM_EABI__ | $CC_FOR_BUILD -E - 2>/dev/null \
- | grep -q __ARM_EABI__
+ | grep __ARM_EABI__ >/dev/null
then
@@ -932,3 +932,3 @@
if echo __ARM_PCS_VFP | $CC_FOR_BUILD -E - 2>/dev/null \
- | grep -q __ARM_PCS_VFP
+ | grep __ARM_PCS_VFP >/dev/null
then
Diff finished at Thu May 28 09:57:35
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- grep >/dev/null instead of grep -q,
Karl Berry <=