[SCM] GNU Inetutils branch, master, updated. inetutils-1_9_4-56-g1a12dcb

[Mats Erik Andersson]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU Inetutils ".

The branch, master has been updated
       via  1a12dcb381d7e64439e95d47938b6a427b10d5b8 (commit)
       via  ef0361c6474f16f244433af3385542a3765ceec1 (commit)
      from  522101f499c0262d702e6aaf2f1165b1616bc45e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=1a12dcb381d7e64439e95d47938b6a427b10d5b8


commit 1a12dcb381d7e64439e95d47938b6a427b10d5b8
Author: Mats Erik Andersson <address@hidden>
Date:   Sun Jan 12 01:15:44 2020 +0100

    Confirm that rcmd functionality is present at all.
    
    Imbedded systems like Alpine Linux with musl libc see no reason
    to offer any rcmd variant.  Adapt to this fact, as reported by
    Assaf Gordon and by Bruno Haible.

diff --git a/ChangeLog b/ChangeLog
index 4171ce2..dbae841 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2020-01-12  Mats Erik Andersson  <address@hidden>
+
+       Suppress building of remote execution commands on systems that
+       offer no rcmd functionality.  This happens with embedded systems
+       like Alpine Linux and musl libc, as reported by Assaf Gordon and
+       Bruno Haible.
+
+       * configure.ac: Check for function rcmd().  Disable building
+       of `rcp', `rlogin', and `rsh' when no rcmd variant is present.
+       (WITH_RCMD): New precompiler macro.
+
 2020-01-11  Mats Erik Andersson  <address@hidden>
 
        The glibc manual page for ether address specifies <netinet/ether.h>.
diff --git a/configure.ac b/configure.ac
index 0a45381..d6c4410 100644
--- a/configure.ac
+++ b/configure.ac
@@ -255,6 +255,15 @@ else
   IU_DISABLE_TARGET(talk)
 fi
 
+# The function rcmd() is crucial for remote shells, but is not
+# always implemented in libraries intended for embedded systems.
+# Check for its availability in order to later disable our rcp,
+# rlogin, and rsh when no alternative is present.
+AC_CHECK_FUNC(rcmd, , , [#include <netdb.h>])
+if test "$ac_cv_func_rcmd" = yes; then
+  AC_DEFINE([WITH_RCMD], 1, [Define to one if you can use rcmd.])
+fi
+
 # NetBSD offers orcmd() and orcmd_af() for getting
 # exactly the functionality that rcmd() and rcmd_af()
 # offer on all other targetted systems.
@@ -310,6 +319,16 @@ else
   fi
 fi
 
+# Disable targets rcp, rlogin, and rsh when no rcmd variant is available.
+if test "$ac_cv_func_rcmd" != yes \
+   && test "$ac_cv_func_orcmd" != yes \
+   && test "$ac_cv_func_rcmd_af" != yes \
+   && "$ac_cv_func_orcmd_af" != yes
+then
+  IU_DISABLE_TARGET(rcp)
+  IU_DISABLE_TARGET(rlogin)
+  IU_DISABLE_TARGET(rsh)
+fi
 
 # FIXME: Make this test case a bit more robust.  Remove KRB4
 LIBAUTH=

http://git.savannah.gnu.org/cgit/inetutils.git/commit/?id=ef0361c6474f16f244433af3385542a3765ceec1


commit ef0361c6474f16f244433af3385542a3765ceec1
Author: Mats Erik Andersson <address@hidden>
Date:   Sat Jan 11 23:17:15 2020 +0100

    Change header inclusion for ifconfig on GNU/Linux.
    
    Conform to manual page recipe for ether_hostton(), attempting
    to succeed on systems with musl libc.  Reported by Bruno Haible.

diff --git a/ChangeLog b/ChangeLog
index d1e49ad..4171ce2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,15 @@
 2020-01-11  Mats Erik Andersson  <address@hidden>
 
+       The glibc manual page for ether address specifies <netinet/ether.h>.
+       Use this for GNU/Linux in the hope of resolving also musl libc, as
+       used with Alpine Linux.  Reported by Bruno Haible.
+
+       * ifconfig/system/linux.c [HAVE_NETINET_ETHER_H]: Include the
+       library header <netinet/ether.h> instead of the system specific
+       header <linux/if_ether.h>.
+
+2020-01-11  Mats Erik Andersson  <address@hidden>
+
        Consistent use of `grep' tools in scripts.
 
        * configure.ac (EGREP, FGREP): New and precious variables.
diff --git a/ifconfig/system/linux.c b/ifconfig/system/linux.c
index 9aa087a..058374c 100644
--- a/ifconfig/system/linux.c
+++ b/ifconfig/system/linux.c
@@ -41,7 +41,9 @@
 #include <sys/ioctl.h>
 #include <net/if.h>
 #include <net/if_arp.h>
-#include <linux/if_ether.h>
+#ifdef HAVE_NETINET_ETHER_H
+# include <netinet/ether.h>
+#endif
 
 #include <read-file.h>
 #include <unused-parameter.h>

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog               | 21 +++++++++++++++++++++
 configure.ac            | 19 +++++++++++++++++++
 ifconfig/system/linux.c |  4 +++-
 3 files changed, 43 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
GNU Inetutils